Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.23 slices.Chunk as a replacement for internal/slices.Chunks, redux #39475

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Use Go 1.23 slices.Chunk as a replacement for internal/slices.Chunks, redux #39475

merged 11 commits into from
Sep 25, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 24, 2024 •
edited
Loading

Description

Use the new Go 1.23 slices.Chunk function as a replacement for our internal/slices.Chunks.

Relations

Relates #39144.
Relates #39256.
Relates #39432.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_withTrafficSourcesELBs
=== PAUSE TestAccAutoScalingGroup_withTrafficSourcesELBs
=== RUN   TestAccAutoScalingGroup_loadBalancers
=== PAUSE TestAccAutoScalingGroup_loadBalancers
=== RUN   TestAccAutoScalingGroup_targetGroups
=== PAUSE TestAccAutoScalingGroup_targetGroups
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_loadBalancers
--- PASS: TestAccAutoScalingGroup_basic (71.10s)
=== CONT  TestAccAutoScalingGroup_targetGroups
--- PASS: TestAccAutoScalingGroup_targetGroups (186.18s)
=== CONT  TestAccAutoScalingGroup_withTrafficSourcesELBs
--- PASS: TestAccAutoScalingGroup_loadBalancers (417.76s)
--- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (227.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	490.643s

@ewbankkit
Revert "Partial reversion of Replace 'tfslices.Chunks' with 'slices.C…
1888d5f 
…hunk' - autoscaling."

This reverts commit a351eb1.
@ewbankkit
Revert "Partial reversion of Replace 'tfslices.Chunks' with 'slices.C…
7e07429 
…hunk' - lakeformation."

This reverts commit b142d28.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - conne…
fd63cda 
…ct.""

This reverts commit c40facf.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - docdb.""
2853f82 
This reverts commit 9ec42d9.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - kafka.""
3d4e255 
This reverts commit f797f26.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - neptu…
eb2084c 
…ne.""

This reverts commit 8ec8670.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - rds.""
13f7f03 
This reverts commit 0c6c637.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - route…
328712e 
…53.""

This reverts commit d1b3b11.
@ewbankkit
Revert "Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - ssm.""
9c86064 
This reverts commit bfff87f.
@ewbankkit
Revert "Revert "Remove 'tfslices.Chunks'.""
fe9ae6b 
This reverts commit 9be946f.
@ewbankkit
Update '.go-version'.
6bcb193
@ewbankkit ewbankkit requested a review from a team as a code owner September 24, 2024 21:02
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. provider Pertains to the provider itself, rather than any interaction with AWS. service/neptune Issues and PRs that pertain to the neptune service. service/connect Issues and PRs that pertain to the connect service. service/kafka Issues and PRs that pertain to the kafka service. service/docdb Issues and PRs that pertain to the docdb service. service/lakeformation Issues and PRs that pertain to the lakeformation service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 24, 2024
jar-b
jar-b approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit ab51281 into main Sep 25, 2024
44 checks passed
@ewbankkit ewbankkit deleted the td-slices.Chunk-redux branch September 25, 2024 15:54
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 25, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 25, 2024
Update CHANGELOG.md for #39475
5a3bdd3
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/connect Issues and PRs that pertain to the connect service. service/docdb Issues and PRs that pertain to the docdb service. service/kafka Issues and PRs that pertain to the kafka service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.69.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b